Adding generalized support for controller usages with the binding path dropdown. Added optional info blurb on the binding paths covered #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…well as listing out the specific device paths that match to a binding
…ages, now shows a message when no matching registered paths exist
…additional contexts
|
Hi @RogPodge, could you migrate this to an internal branch (rather than a external fork) so that the CI jobs run on it? |
4 tasks
|
This is an old PR. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR augments the binding path dropdown, allowing users to add control usages for specific devices.
This PR also adds a "Show Matching Paths" checkbox, which shows the users exactly which specific registered layout paths their current binding path will match with.
The goal of this PR is to address some grievances found in this thread: https://forum.unity.com/threads/openxr-primary2daxisclick-not-working.1120864/
General.Binding.Editing.mp4
Failure.Case.mp4
Changes made
Updated the InputControlPickerDropdown to allow for control usages to be selected and added to the paths in after specifying a desired device.
Augmented the UsageDropdown to be usable in more contexts.
Added unit tests for the new InputControlPath function.
Added new option to the InputBindingsPropertiesView.
Notes
Please write down any additional notes, remove the section if not applicable.
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.